IBX-10735: Leverage new Content Type Search API #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
force-pushed
the
use-findContentTypes-in-content-type-list
branch
from
e991be0 to
0462d36
Compare
barw4
changed the title
findContentTypes PAPI contract in content type list
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
ViniTou,
wiewiurdp,
konradoboza and
tbialcz
and removed request for
a team
konradoboza
reviewed
Oct 6, 2025
konradoboza
approved these changes
Oct 6, 2025
tbialcz
approved these changes
Oct 6, 2025
Steveb-p
reviewed
Oct 6, 2025
konradoboza
reviewed
Oct 6, 2025
Steveb-p
approved these changes
Oct 6, 2025
|
|
||
| $adapter = new ContentTypeListAdapter($this->contentTypeService, $languages); | ||
|
|
||
| self::assertEquals( |
There was a problem hiding this comment.
Suggested change
| self::assertEquals( | |
| self::assertSame( |
There was a problem hiding this comment.
assertSame doesn't seem to work, these won't be exactly the same types?
| $this->contentTypeService | ||
| ->expects(self::once()) | ||
| ->method('findContentTypes') | ||
| ->with($this->isInstanceOf(ContentTypeQuery::class), $languages) |
There was a problem hiding this comment.
You may also want to make the check more specific, utilizing
self::callback(function (ContentTypeQuery $query): bool {
// ...
return true;
})constraint.
Suggested change
| ->with($this->isInstanceOf(ContentTypeQuery::class), $languages) | |
| ->with(self::isInstanceOf(ContentTypeQuery::class), $languages) |
|
adamwojs
approved these changes
Oct 7, 2025
barw4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/core#633
Description:
This PR replaces the old
ArrayAdapterwith a dedicated one that utilizes a newfindContentTypesPAPI contract.For QA:
We need to check whether the content type list behaves exactly the same as before, potentially we could check what's the performance gain.
Documentation: